diff --git a/projects/plugins/jetpack/changelog/fix-translation-issues b/projects/plugins/jetpack/changelog/fix-translation-issues new file mode 100644 index 0000000000000..52d5c014cf966 --- /dev/null +++ b/projects/plugins/jetpack/changelog/fix-translation-issues @@ -0,0 +1,4 @@ +Significance: patch +Type: other + +Fix translation issues for default attributes diff --git a/projects/plugins/jetpack/extensions/blocks/subscriptions/subscriptions.php b/projects/plugins/jetpack/extensions/blocks/subscriptions/subscriptions.php index 32c29b156b593..0b985dae81337 100644 --- a/projects/plugins/jetpack/extensions/blocks/subscriptions/subscriptions.php +++ b/projects/plugins/jetpack/extensions/blocks/subscriptions/subscriptions.php @@ -60,6 +60,88 @@ function register_block() { ), 'align' => array( 'wide', 'full' ), ), + 'attributes' => array( + 'subscribePlaceholder' => array( + 'type' => 'string', + 'default' => __( 'Type your email…', 'jetpack' ), + ), + 'showSubscribersTotal' => array( + 'type' => 'boolean', + 'default' => false, + ), + 'includeSocialFollowers' => array( + 'type' => 'boolean', + ), + 'buttonOnNewLine' => array( + 'type' => 'boolean', + 'default' => false, + ), + 'buttonWidth' => array( + 'type' => 'string', + ), + 'submitButtonText' => array( + 'type' => 'string', + 'default' => __( 'Subscribe', 'jetpack' ), + ), + 'emailFieldBackgroundColor' => array( + 'type' => 'string', + ), + 'customEmailFieldBackgroundColor' => array( + 'type' => 'string', + ), + 'emailFieldGradient' => array( + 'type' => 'string', + ), + 'customEmailFieldGradient' => array( + 'type' => 'string', + ), + 'buttonBackgroundColor' => array( + 'type' => 'string', + ), + 'customButtonBackgroundColor' => array( + 'type' => 'string', + ), + 'buttonGradient' => array( + 'type' => 'string', + ), + 'customButtonGradient' => array( + 'type' => 'string', + ), + 'textColor' => array( + 'type' => 'string', + ), + 'customTextColor' => array( + 'type' => 'string', + ), + 'fontSize' => array( + 'type' => 'string', + ), + 'customFontSize' => array( + 'type' => 'string', + ), + 'borderRadius' => array( + 'type' => 'number', + ), + 'borderWeight' => array( + 'type' => 'number', + ), + 'borderColor' => array( + 'type' => 'string', + ), + 'customBorderColor' => array( + 'type' => 'string', + ), + 'padding' => array( + 'type' => 'number', + ), + 'spacing' => array( + 'type' => 'number', + ), + 'successMessage' => array( + 'type' => 'string', + 'default' => __( 'Success! An email was just sent to confirm your subscription. Please find the email now and click \'Confirm Follow\' to start subscribing.', 'jetpack' ), + ), + ), ) ); } @@ -764,7 +846,7 @@ class="screen-reader-text" esc_attr( $subscribe_field_id ), ( ! empty( $data['subscribe_email'] ) ? 'disabled title="' . esc_attr__( "You're logged in with this email", 'jetpack' ) . '"' - : '' + : 'title="' . esc_attr__( 'Please fill in this field.', 'jetpack' ) . '"' ) ); ?> diff --git a/projects/plugins/jetpack/modules/sharedaddy/sharing-service.php b/projects/plugins/jetpack/modules/sharedaddy/sharing-service.php index 1e2b4a8a30de0..b190974c77311 100644 --- a/projects/plugins/jetpack/modules/sharedaddy/sharing-service.php +++ b/projects/plugins/jetpack/modules/sharedaddy/sharing-service.php @@ -501,7 +501,7 @@ public function get_global_options() { } } - if ( false === $this->global['sharing_label'] ) { + if ( false === $this->global['sharing_label'] || $this->global['sharing_label'] === 'Share this:' ) { $this->global['sharing_label'] = $this->default_sharing_label; }