Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking single image to gallery carousel view breaks if clicked > once #6139

Open
aheckler opened this issue Jan 20, 2017 · 4 comments
Open
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@aheckler
Copy link
Member

To reproduce:

  1. Enable Carousel.
  2. Create a new page with a gallery of images.
  3. Elsewhere on the page, insert a standalone image that links to a carousel URL from the gallery. Example: http://example.com/2016/12/the-permalink-here/#jp-carousel-123.
  4. Publish page and open it.
  5. Click the standalone image. The carousel view of the gallery opens as expected.
  6. Close out of the carousel view.
  7. Click the standalone image again. Nothing happens.

It also "works" in reverse. If you click the gallery first instead of the standalone image, carousel opens. But then if you close it and click the single image, nothing happens.

3004435-t

@aheckler aheckler added [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended labels Jan 20, 2017
@jeherve jeherve added this to the Not Currently Planned milestone Jan 23, 2017
@stoyan0v
Copy link
Contributor

stoyan0v commented Jan 30, 2017

This also "works" if you open a new tab and paste the link directly, then when you close the carousel you are redirected back to empty tab.

Steps to reproduce:

  1. Copy the link that opens the carousel, for example ( http://example.com/2016/12/the-permalink-here/#jp-carousel-123 )
  2. Open a new tab and paste the link.
  3. Close the carousel

What I expected

To stay on page when the carousel is closed.

What happened instead

I was redirected back to empty tab.

@ebinnion
Copy link
Contributor

I ran into this second flow today on my personal blog. Going to https://eric.blog/#jp-carousel-8080 and then exiting out of the gallery results in me being taken to an empty tab.

@proudfoot
Copy link
Contributor

I'm running into this issue exactly as described in the original post.

When the stand alone image is clicked after closing the gallery, the #jp-carousel-123 part of the URL is appended in the address bar and then immediately removed. The browser back button flashes at the same time.

The similar unrequested back navigation to an empty tab mentioned by @stoyan0v above is also described in #6244

@stale
Copy link

stale bot commented Jul 3, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Jul 3, 2018
@kraftbj kraftbj removed this from the Not Currently Planned milestone Jan 26, 2021
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Jan 26, 2021
@stale stale bot removed the [Status] Stale label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

7 participants