Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Boost] Image Guide compatibility with Tiled Gallery #28246

Closed
thingalon opened this issue Jan 10, 2023 · 2 comments
Closed

[Boost] Image Guide compatibility with Tiled Gallery #28246

thingalon opened this issue Jan 10, 2023 · 2 comments
Assignees
@pyronaur @dilirity
Labels
[JS Package] Image Guide [Plugin] Boost A feature to speed up the site and improve performance. [Type] Bug When a feature is broken and / or not performing as intended
Milestone
Boost/1.7.0

Comments

@thingalon
Copy link
Member

thingalon commented Jan 10, 2023 •
edited by dilirity
Loading

As pointed out by @jeherve, the Image Guide is not showing up properly when used with Jetpack's Tiled Image Gallery.

Popup information frames are appearing inside individual panes, cutting off most of their content.

We need to ensure that this feature works with other Jetpack features.
@thingalon thingalon added the [Type] Bug When a feature is broken and / or not performing as intended label Jan 10, 2023
@thingalon
Copy link
Member Author

The only reliable way I can see to fix this, is to move the information popup to a layer at the document level with a high z-index, and position it absolutely using JavaScript to match the bubble's position.

Other ideas welcome, but I don't see another way for this.

@jeherve jeherve added [Plugin] Boost A feature to speed up the site and improve performance. [JS Package] Image Guide labels Jan 10, 2023
@thingalon thingalon added this to the Boost/1.7.0 milestone Jan 11, 2023
@pyronaur
Copy link
Member

Fixed in #28026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pyronaur pyronaur

@dilirity dilirity

Labels
[JS Package] Image Guide [Plugin] Boost A feature to speed up the site and improve performance. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
Boost/1.7.0
Development

No branches or pull requests
4 participants
@jeherve @pyronaur @thingalon @dilirity