Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress: local video being rendered on the VideoPress video list #27848

Closed
lhkowalski opened this issue Dec 8, 2022 · 0 comments · Fixed by #28237
Closed

VideoPress: local video being rendered on the VideoPress video list #27848

lhkowalski opened this issue Dec 8, 2022 · 0 comments · Fixed by #28237
Assignees
Labels
[Package] VideoPress [Type] Bug When a feature is broken and / or not performing as intended

Comments

@lhkowalski
Copy link
Contributor

lhkowalski commented Dec 8, 2022

For some reason, a local video is being rendered inside the VideoPress video list.

Initially I tought it was an issue on my working branch, but I tested on trunk and I am still getting the bug.

Steps to reproduce:

  • Launch a test site
  • Upload one video to the media gallery before activating VideoPress (Media > Add new)
  • Activate and connect VideoPress
  • The library screen seems correct:

Screen Shot 2022-12-08 at 19 34 26

  • Now upload one video to the VideoPress library
  • You will see the new video and the local one together on the video grid/list:

Screen Shot 2022-12-08 at 19 35 27

  • Notice that the VideoPress video count is correct
  • The issue persists even after a page refresh:

Screen Shot 2022-12-08 at 19 43 46

  • The initial state provided by the backend is correct, containing only the VideoPress video:

Screen Shot 2022-12-08 at 19 37 14

  • The local store state contains both videos, so maybe a recent change is messing with the state:

Screen Shot 2022-12-08 at 19 45 31

  • If I add more videos, the local one is still there:

Screen Shot 2022-12-08 at 19 48 27

  • After a refresh, the local one goes to the init of the list
  • Debugging the state, I see that the local item is added to the list of VideoPress videos after this SET_VIDEO action finishes:

Screen Shot 2022-12-08 at 19 50 07

  • This only happens on the first page of videos, but will not happen if I get to the first page using the navigation controllers, so may be something related to how we are handling the initial state of the app:

Screen Shot 2022-12-08 at 19 55 06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] VideoPress [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants