Blocks: Video vs VideoPress blocks

[kraftbj]

Within WordPress Core, since it supports VideoPress oembeds out of the box, it generates a VideoPress block.

Our own work to better support Jetpack Videos/VideoPress is by amending the Core video block.

This may be confusing to customers, so should/could we suppress the VideoPress block in some way?

Steps to reproduce the issue

1. Go to Block Editor with a Jetpack site with video hosting enabled.
2. Click the UI to add a new block.
3. See both a Video and VideoPress block.

What I expected

No confusion on what block to use.

What happened instead

It can be confusing.

When pasting a VideoPress link, auto-converting to a VideoPress block is fine, but could we just remove it as an option in the new block UI?

cc: @mmtr

[mmtr]

Thanks for opening this issue @kraftbj! I agree this can confuse users.

I also agree that preventing to add VideoPress blocks from the block inserter looks like a good way to avoid the confusion.

[simison]

@rickybanister brought this up in Slack convo. (p1556116967006400-slack-jetpack-gutenberg)

Note that APIs for "soft disabling" blocks are now much better in Gutenberg with the release of "Block manager". It's possible to hide the VideoPress embed block from block picker without breaking previously added VideoPress embeds in old content (i.e. hide in block picker as opposite to disable it entirely).

Some code snipped examples:
WordPress/gutenberg#14139 (comment)

https://wordpress.org/gutenberg/handbook/designers-developers/developers/data/data-core-edit-post/#hideblocktypes

Also WordPress/gutenberg#12931

[simison]

I'll remove "bug" label since this is more confusing UI than it is a "bug". :-)