From 86d3c5b2833591c89ca6b425cf16f9fc0ea997f1 Mon Sep 17 00:00:00 2001 From: Manzoor Wani Date: Wed, 20 Dec 2023 13:31:37 +0530 Subject: [PATCH] Fix the media validation notice shown even when auto conversion is enabled. (#34730) Co-authored-by: Gergely Juhasz --- .../changelog/fix-media-validation-notice | 4 ++++ .../publicize-components/src/components/form/index.js | 1 + .../src/components/form/validation-notice.tsx | 4 +++- 3 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 projects/js-packages/publicize-components/changelog/fix-media-validation-notice diff --git a/projects/js-packages/publicize-components/changelog/fix-media-validation-notice b/projects/js-packages/publicize-components/changelog/fix-media-validation-notice new file mode 100644 index 0000000000000..18c93a5623f45 --- /dev/null +++ b/projects/js-packages/publicize-components/changelog/fix-media-validation-notice @@ -0,0 +1,4 @@ +Significance: patch +Type: fixed + +Fixed the media validation notice shown even when auto conversion is enabled. diff --git a/projects/js-packages/publicize-components/src/components/form/index.js b/projects/js-packages/publicize-components/src/components/form/index.js index 5a034bbdcf1ba..05785d79164e6 100644 --- a/projects/js-packages/publicize-components/src/components/form/index.js +++ b/projects/js-packages/publicize-components/src/components/form/index.js @@ -118,6 +118,7 @@ export default function PublicizeForm() { ) ) } diff --git a/projects/js-packages/publicize-components/src/components/form/validation-notice.tsx b/projects/js-packages/publicize-components/src/components/form/validation-notice.tsx index 5a6db2d6cd797..47871f62de7c3 100644 --- a/projects/js-packages/publicize-components/src/components/form/validation-notice.tsx +++ b/projects/js-packages/publicize-components/src/components/form/validation-notice.tsx @@ -6,13 +6,15 @@ import Notice from '../notice'; export type ValidationNoticeProps = { connectionsCount: number; invalidConnectionIdsCount: number; + shouldAutoConvert: boolean; }; export const ValidationNotice: React.FC< ValidationNoticeProps > = ( { connectionsCount, invalidConnectionIdsCount, + shouldAutoConvert, } ) => { - return ( + return shouldAutoConvert ? null : (

{ connectionsCount === invalidConnectionIdsCount