Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote 1 #23

Closed
iamtakashi opened this issue Mar 19, 2020 · 4 comments
Closed

Quote 1 #23

iamtakashi opened this issue Mar 19, 2020 · 4 comments

Comments

@iamtakashi
Copy link
Contributor

Semantically, it should use a Quote block, but it lacks color setting, so I used a Paragraph block at the moment. (Yes, I'll open an issue for Quote block 😊)

quote-1

<!-- wp:cover {"overlayColor":"background-light","align":"full"} -->
<div class="wp-block-cover alignfull has-background-light-background-color has-background-dim"><div class="wp-block-cover__inner-container"><!-- wp:jetpack/layout-grid {"addGutterEnds":false,"column1DesktopSpan":8,"column1DesktopOffset":2,"column1TabletSpan":8,"column1MobileSpan":4,"column2DesktopOffset":4,"className":"column1-desktop-grid__span-8 column1-desktop-grid__start-3 column1-desktop-grid__row-1 column1-tablet-grid__span-8 column1-tablet-grid__row-1 column1-mobile-grid__span-4 column1-mobile-grid__row-1"} -->
<div class="wp-block-jetpack-layout-grid alignfull column1-desktop-grid__span-8 column1-desktop-grid__start-3 column1-desktop-grid__row-1 column1-tablet-grid__span-8 column1-tablet-grid__row-1 column1-mobile-grid__span-4 column1-mobile-grid__row-1 wp-block-jetpack-layout-gutter__nowrap"><!-- wp:jetpack/layout-grid-column -->
<div class="wp-block-jetpack-layout-grid-column wp-block-jetpack-layout-grid__padding-none"><!-- wp:spacer {"height":32} -->
<div style="height:32px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:separator {"color":"foreground"} -->
<hr class="wp-block-separator has-text-color has-background has-foreground-background-color has-foreground-color"/>
<!-- /wp:separator -->

<!-- wp:paragraph {"align":"center","textColor":"foreground","fontSize":"large"} -->
<p class="has-text-color has-text-align-center has-large-font-size has-foreground-color">"The artist is the creator of beautiful things. To reveal art and conceal the artist is art's aim. The critic is he who can translate into another manner or a new material his impression of beautiful things"</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"align":"center","textColor":"foreground"} -->
<p class="has-text-color has-text-align-center has-foreground-color">Oscar Wilde</p>
<!-- /wp:paragraph -->

<!-- wp:separator {"color":"foreground"} -->
<hr class="wp-block-separator has-text-color has-background has-foreground-background-color has-foreground-color"/>
<!-- /wp:separator -->

<!-- wp:spacer {"height":32} -->
<div style="height:32px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer --></div>
<!-- /wp:jetpack/layout-grid-column --></div>
<!-- /wp:jetpack/layout-grid --></div></div>
<!-- /wp:cover -->
@iamtakashi
Copy link
Contributor Author

Semantically, it should use a Quote block, but it lacks color setting, so I used a Paragraph block at the moment. (Yes, I'll open an issue for Quote block 😊)

Found this: WordPress/gutenberg#8171 where suggests using the inline text color option.

But, I think I'm going to keep the paragraph for now because it still lacks a size option.

@ianstewart
Copy link

While we're trying to treat (at this time) pattern content as more like Lorem Ipsum I wonder if this content could create confusion with a text block? I've seen @alaczek use a pattern like this for a Testimonial. I wonder if that might work better? (Though I obviously like the Oscar Wilde quote since I pulled it the other day.) :)

@ianstewart
Copy link

Yes, I'll open an issue for Quote block

Perfect. :)

@iamtakashi
Copy link
Contributor Author

While this made me realized the state of Quote block, but this is something that style variation in the block could handle. Scraping it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants