Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout Grid: column vertical alignment doesn't work in preview #250

Closed
zaguiini opened this issue Dec 10, 2021 · 13 comments · Fixed by #254
Closed

Layout Grid: column vertical alignment doesn't work in preview #250

zaguiini opened this issue Dec 10, 2021 · 13 comments · Fixed by #254
Labels
Bug Something isn't working

Comments

@zaguiini
Copy link
Contributor

It works fine on the live site. However, preview always displays the column's contents at the top, vertically speaking.

Preview Live site
image image

Notice how the center alignment option is selected in the Column block.

@jasmussen
Copy link
Member

Thanks for the ticket! Do you have additional steps to reproduce? I'm seeing the correct alignment both in the editor and the frontend:
Screenshot 2021-12-13 at 10 55 17

@zaguiini
Copy link
Contributor Author

Interesting. It might be Dotcom specific, then?

Or, it might be related to possibly outdated block pattern markup? I'll need to check.

@zaguiini
Copy link
Contributor Author

It might be Dotcom specific, then?

It is. I'm able to reproduce the problem there. Can you please try it as well, @jasmussen?

@jasmussen
Copy link
Member

In a quick test, it worked fine. Which theme are you testing with?

@zaguiini
Copy link
Contributor Author

Quadrat. How are you testing it?

My instructions:

  1. Add Layout Grid;
  2. Add Image to the first column;
  3. Add Paragraph to the second column;
  4. Try to vertically align the second column.

I'll try on core WP again.

@jasmussen
Copy link
Member

Testing with the same steps:
Screenshot 2021-12-13 at 18 33 20

@zaguiini
Copy link
Contributor Author

zaguiini commented Dec 13, 2021

LOL, I'm questioning my own sanity at this point 😄

This is what I get on Core WP:

image

@jasmussen
Copy link
Member

This is the quadrat theme customized white? I'll take a look again. Theme and other plugins are important too, as sometimes their css can bleed into other blocks.

@zaguiini
Copy link
Contributor Author

zaguiini commented Dec 13, 2021

This time it was TT2, not Quadrat. Sorry for not making it explicit.

@jasmussen
Copy link
Member

I can reproduce in the site editor, not in the post editor. Taking a look.

@jasmussen
Copy link
Member

Very curious. The markup and CSS appears to be mostly the same, but I can indeed reproduce the issue here. I'll take a stab at fixing this tomorrow. Thanks for the report!

@zaguiini
Copy link
Contributor Author

Oh, so that was the missing bit! My bad, I'm so used at working on the FSE that I forgot there's more than that 😓

@jasmussen
Copy link
Member

There really shouldn't be, but for the near future, the site editor is iframed and the post editor is not. I would hope we can iframe both, so the target should be more uniform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
2 participants