Add code quality checking via phpcs, eslint, jscs, and jshint #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
westonruter
commented
Nov 5, 2017
westonruter
commented
- Limit checking of code to the lines that are modified in scope of the pull request; this will allow for adherence to linting rules to be applied incrementally in the context of PRs without having to fix everything up front in order to get a passing build.
- Fix i18n errors related to UnorderedPlaceholdersText and MissingArgDomain.
- Add wp-dev-lib, which is added as submodule.
- Re-use phpunit bootstrap from wp-dev-lib.
- Update Travis to use container-based environment and use caching to improve performance.
amedina
approved these changes
Nov 6, 2017
|
Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.