Add initial AMP support for Twenty Nineteen #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienstra
approved these changes
Nov 4, 2018
There was a problem hiding this comment.
Approved
Hi @westonruter,
This looks good, and validation of the site with Twenty Nineteen shows no validation error.
Before
After
| @@ -141,7 +141,8 @@ public function render_theme_support() { | |||
| $theme_support = AMP_Options_Manager::get_option( 'theme_support' ); | |||
| $paired_description = __( 'Reuses active theme\'s templates to display AMP responses, but uses separate URLs for AMP. The canonical URLs for your site will not have AMP. If there are AMP validation errors encountered in the AMP response and the validation errors are not accepted for sanitization, then the AMP version will redirect to the non-AMP version.', 'amp' ); | |||
| $native_description = __( 'Reuses active theme\'s templates to display AMP responses but does not use separate URLs for AMP. Your canonical URLs are AMP. AMP-specific blocks are available for inserting into content. Any AMP validation errors are automatically sanitized.', 'amp' ); | |||
| $builtin_support = in_array( get_template(), array( 'twentyfifteen', 'twentysixteen', 'twentyseventeen' ), true ); | |||
|
|
|||
| $builtin_support = in_array( get_template(), AMP_Core_Theme_Sanitizer::get_supported_themes(), true ); | |||
There was a problem hiding this comment.
Good idea to abstract this into a method.
4 tasks
westonruter
changed the title
westonruter
force-pushed
the
add/twentynineteen-compat
branch
from
3ae13a7 to
e09c826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are outstanding things todo here, including:
focusableattribute: ✨ Allow SVG 'focusable' attribute from SVG Tiny 1.2 amphtml#19128@charset: Strip @charset CSS at-rules #1515@page(optional: can be done as part of Update AMP spec to 757 (v1811091519050) #1588).Fixes #1515.