Add default values for AMP Timeago block #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Claudio reported, there's an error when using the AMP Timeago block with the default values The layout is inially responsive, which requires both a width an height. And another option of fixed also requires a width and height. So set fixed-height as the default layout, as set a default height of 20. This is the value in the documentation example. So at least this block with the default values won't have a validation error @see https://www.ampproject.org/ko/docs/reference/components/amp-timeago
|
Request For Code Review Hi @westonruter, Thanks, and have a great weekend. |
westonruter
approved these changes
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @csossi for reporting this in #1580.
Creating an AMP Timeago block with the default values causes a validation error in the Chrome extension because it doesn't have the required
heightvalue:So this sets a default value of
20for the height. This is the value in this example.It also sets the default layout to
fixed-height. This is the only layout available that doesn't require awidth(there's no default width in the editor):Fixes #1580