Make the default layout responsive for the <amp-ooyala-player> block #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Claudio pointed out, the default layout of fixed can cause it to overflow the container. responsive seems to keep the width to the container size in Twenty Fifteen, Sixteen, and Seventeen. Still, if the content area is floated, like in a mobile-first grid, a fixed layout might work better. Responsive layouts mean the element only has the width of its parent. But there's a <select> in the block editor to change this.
kienstra
changed the title
|
Request For Review Hi @westonruter, Could you please review this? |
westonruter
approved these changes
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @csossi for reporting this in #1581.
Steps To Reproduce
Video embed code (required):
Vxc2k0MDE6Y_C7J5podo3UDxlFxGaZrQPlayer ID (required):
6440813504804d76ba35c8c787a4b33cProvider code for the account (required):
5zb2wxOlZcNCe_HVT3a6cawW298XLeave the defaults for the rest:
<amp-ooyala-player>remains within its containerresponsiveseems to keep the width to the container size in Twenty Fifteen, Sixteen, and Seventeen.fixedtoresponsive.fixedlayout might work better. Responsive layouts mean the element only has the width of its parent. But there's a<select>in the block editor to change this to something likefixedif needed.Fixes #1581