Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AMP Invalid URLs to AMP Validated URLs #1487

Merged
merged 11 commits into from
Oct 4, 2018
Merged

Rename AMP Invalid URLs to AMP Validated URLs #1487

merged 11 commits into from
Oct 4, 2018

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Oct 4, 2018 •
edited by westonruter
Loading

  • Changes the labels on the post type index page and the 'AMP Validation Error Index.'
  • Updates comments that reference that page from 'Invalid URLs' to 'AMP Validation URLs'
  • Updates post type slug from amp_invalid_url to amp_validated_url.
  • Updates class name from AMP_Invalid_URL to AMP_Validated_URL.
  • Updates filenames and other references with s/invalud/validated/

Before

before-invalid-urls

After

after-invalid-urls

after-error-index

kienstra and others added 5 commits October 4, 2018 13:16
@kienstra
Change labels for validation post type
7247bbf 
The name is now 'AMP Validated URLs',
and the menu name is 'Validated URLs.'
But this does not change the slug,
as that probably belongs in a separate PR
that replaces the post_type of existing posts.
@kienstra
Update references to the Invalid URLs in comments to AMP Validation URLs
484a9ae 
Only for AMP_Validation_Error_Taxonomy,
as the previous commit applied to
AMP_Invalid_URL_Post_Type.
@westonruter
Update post type from amp_invalid_url to amp_validated_url
bdefaaa
@westonruter
Rename files from amp-invalid to amp-validated
d46b80c
@westonruter
Reduce AMP redundancy for page-title-action
46da438
@westonruter westonruter changed the title Change validation post type labels Rename AMP Invalid URLs to AMP Validated URLs Oct 4, 2018
kienstra
kienstra commented Oct 4, 2018
View reviewed changes
amedina
amedina approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the branch and everything is in place. LGTM!

@westonruter westonruter added this to the v1.0 milestone Oct 4, 2018
@kienstra
Copy link
Contributor Author

kienstra commented Oct 4, 2018

Approved

Hi @westonruter,
This looks good.

On pulling checking out this branch and loading a page, the post types are updated as expected.

Before

before-change-post-type

After

after-counts-appear-same

Also, the version is stored in an option, as expected:
version-stored

@westonruter westonruter merged commit 5ce3414 into 1.0 Oct 4, 2018
@westonruter westonruter deleted the update/post-type-label branch October 4, 2018 23:15
@kienstra
Copy link
Contributor Author

kienstra commented Oct 5, 2018

Looks Good On Staging

Getting ready for the RC1 release, I uploaded the built amp.zip to some staging sites.

The new logic looks to have converted the post types well.

https://paired-ampconfdemo.pantheonsite.io
new-post-type

https://native-ampconfdemo.pantheonsite.io
native-post-type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@amedina amedina amedina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kienstra @westonruter @amedina