Fix conversion of video to amp-video #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conversion There is no need to remove unrecognized attributes because these will be handled by the whitelist sanitizer. Also preserve all original child nodes of video so that track elements will be preserved.
|
Approved, Thanks For Fixing HI @westonruter, The videos still appear as expected, and there's no ‘Undefined index: src’ warning, like before.
I should have caught that earlier in #1474. Did you tail the error log from within VVV? tail -f /srv/www/example-site/log/error.log |
kienstra
approved these changes
Sep 28, 2018
| } | ||
| $sources_count++; | ||
| $child_node->setAttribute( 'src', $src ); | ||
| $new_attributes = $this->filter_video_dimensions( $new_attributes, $src ); |
There was a problem hiding this comment.
Good idea to pass $src to $this->filter_video_dimensions().
|
Yes, I found the issue by tailing the error log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in #1474.
Given a video widget generated from the non-AMP version as follows:
I was seeing this in the error log in AMP:
If I fixed this problem (dd21353) then I get another regression in that the video gets the default height of 400 (with the aspect ratio no longer being landscape):
So then I went deeper with additional fixes in cf6d2a2 and now I get what is expected:
This PR also ensures that
trackchildren ofvideoare not removed, and that the first non-source/trackelement child gets afallbackattribute added.