Defer adding post type support until post types have been registered #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post types are supposed to be registered at the
initaction, normally at priority 10. For example Jetpack's Testimonial and Portfolio post types. However, the call to registeramppost type support:https://github.com/Automattic/amp-wp/blob/84c1ab11811d0bb056e61b04d157c2d54a435434/amp.php#L153
Happens at
initpriority0:https://github.com/Automattic/amp-wp/blob/84c1ab11811d0bb056e61b04d157c2d54a435434/amp.php#L127
This prevents custom post types from being included in the eligible post types for AMP support.
The fix is just to defer the post type support addition to a later priority in the
initaction.