Update admin screen access #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actions Skip showing admin bar item if user cannot validate someone else's post.
|
@postphotos this fixes the issue you noted when a non-admin tries to access AMP screens. |
|
Approved Hi @weston, This looked good, when testing it for an administrator, editor, and author.
|
kienstra
approved these changes
Sep 17, 2018
| @@ -553,14 +553,21 @@ public function render_screen() { | |||
| AMP_Options_Manager::check_supported_post_type_update_errors(); | |||
| } | |||
| ?> | |||
| <?php if ( ! current_user_can( 'manage_options' ) ) : ?> | |||
| <div class="notice notice-info"> | |||
| <p><?php esc_html_e( 'You do not have permission to modify these settings. They are shown here for your reference. Please contact your administrator to make changes.', 'amp' ); ?></p> | |||
There was a problem hiding this comment.
Good idea to display this notice.
| @@ -1019,12 +1052,19 @@ public static function handle_validate_request() { | |||
| if ( ! $post || self::POST_TYPE_SLUG !== $post->post_type ) { | |||
| throw new Exception( 'invalid_post' ); | |||
| } | |||
| if ( ! current_user_can( 'edit_post', $post->ID ) ) { | |||
| throw new Exception( 'unauthorized' ); | |||
There was a problem hiding this comment.
Good idea to check the capability here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the AMP validation screens are generally available to users who can
edit_posts, in reality this should be tightened up to just administrators, with authors then only able to access theamp_invalid_urlscreens with just the posts that they themselves were responsible for creating in the course of creating regular posts.