Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent erroneously tree-shaking keyframe selectors like 'from', 'to', and percentages #1211

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Jun 13, 2018

Tree shaking was erroneously removing keyframes selectors, turning:

@keyframes foo { 
    from { opacity:0; } 
    to { opacity:1; }  }
}

into

@keyframes foo {}

Obviously this is wrong.

@westonruter westonruter added this to the v1.0 milestone Jun 13, 2018
@amedina amedina self-requested a review June 14, 2018 11:45
Copy link
Member

@amedina amedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ship it!

@westonruter westonruter merged commit 9461da6 into develop Jun 14, 2018
@westonruter westonruter deleted the fix/keyframes-tree-shaking branch June 14, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants