Adding sanitizer to support amp-o2-player #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
westonruter
reviewed
Jun 10, 2018
| */ | ||
| public function __construct( DOMDocument $dom, array $args = array() ) { | ||
| parent::__construct( $dom, $args ); | ||
| $this->xpath = new DOMXPath( $dom ); |
There was a problem hiding this comment.
The xpath setting here could just as well be moved to the sanitize method since that is where it is used. This would avoid needing to override the constructor at all, and if the sanitizers are instantiated but never call sanitize then we could avoid needlessly instantiating this object (however rare that may be).
| private static $height = '270'; | ||
|
|
||
| /** | ||
| * Width to set for 02 Player elements. |
| public static $xpath_selector = '//div[ contains( @class, \'vdb_player\' ) ]/script'; | ||
|
|
||
| /** | ||
| * Height to set for 02 Player elements. |
| * @see https://www.ampproject.org/docs/reference/components/amp-o2-player | ||
| */ | ||
| class AMP_O2_Player_Sanitizer extends AMP_Base_Sanitizer { | ||
| const URL_PATTERN = '#.*delivery.vidible.tv\/jsonp\/pid=(.*)\/vid=(.*)\/(.*).js.*#i'; |
There was a problem hiding this comment.
Would be good to add phpdoc for this.
| * @see https://www.ampproject.org/docs/reference/components/amp-o2-player | ||
| */ | ||
| class AMP_O2_Player_Sanitizer extends AMP_Base_Sanitizer { | ||
| const URL_PATTERN = '#.*delivery.vidible.tv\/jsonp\/pid=(.*)\/vid=(.*)\/(.*).js.*#i'; |
There was a problem hiding this comment.
Might want to use named capture groups to make it easier to reference the $matches.
| * Class AMP_O2_Player_Sanitizer | ||
| * | ||
| * Converts <div class="vdb_player><script></script></div> embed to <amp-o2-player> | ||
| * |
There was a problem hiding this comment.
Could you add @since 1.0 tag to the class (at least)?
westonruter
approved these changes
Jun 20, 2018
…dding-amp-o2-player-sanitizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for amp-o2-player
e.g: If we have the following markup
We should be able to render: