Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

God Mode: Physics #990

Merged
merged 16 commits into from
Jun 27, 2024
Merged

God Mode: Physics #990

merged 16 commits into from
Jun 27, 2024

Conversation

azaleacolburn
Copy link
Contributor

Description

Created a function to create and attach a "ghostBody" to some other body using a SwingTwist (Ball and Socket) constraint. The ghostBody's purpose is to control the original body, changing the position of the ghostBody will "swing" the original body along with it. The intention of this function is to be called when a user in "god mode" clicks on an object.

Objectives

  • Create a ghostBody function
  • Add a button to the main HUD labeled "Test God Mode," to test this ghostBody function on an arbitrary robot (at the moment, the first robot in the sceneObjects list). When clicked, the button creates and then attaches a ghost body to the robot, then repositions the it in order to move the robot.

Testing Done

  • Very basic unit testing to ensure the ghostBody and constraint are actually created
  • Used the aforementioned testing button to check behavior.

JIRA Issue

@azaleacolburn azaleacolburn requested a review from a team as a code owner June 24, 2024 22:42
@azaleacolburn azaleacolburn requested review from HunterBarclay and a-crowell and removed request for a team June 24, 2024 22:42
@HunterBarclay HunterBarclay changed the title Colbura/1675/god-mode-physics God Mode: Physics Jun 24, 2024
@BrandonPacewic BrandonPacewic added the gameplay Relating to the playability of Synthesis label Jun 25, 2024
Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the joint is creating some odd behavior, especially as the joints kind of fail to get into compliance with any urgency. See specifics below

@HunterBarclay HunterBarclay self-requested a review June 25, 2024 16:41
Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions for adding controllable anchor point along with ghost body

@HunterBarclay
Copy link
Member

@Ewie21 Could you make sure you specify the mPoint1 and mPoint2 of the point constraint to be the anchor point. When driving the robot off the platform and testing the godmode, the anchor point is still defaulted to the origin of the world since the points are not set.

@HunterBarclay
Copy link
Member

HunterBarclay commented Jun 26, 2024

@Ewie21 It looks like one of the unit tests is failing; however, if I run it separately, it works. I think we may be hitting the memory limit. I'm going to try and see if I can find some more information

@HunterBarclay HunterBarclay mentioned this pull request Jun 26, 2024
Copy link
Contributor

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool!

From Autodesk/synthesis : colbura/1675 now? It looks a commit ahead.

@HunterBarclay what are you looking for? Ghost body in the same place as the robot's initial position and worrying about gravity later?

@HunterBarclay
Copy link
Member

@a-crowell We'll worry about it later. My raycasting code will supply the initial contact point and the ghost body will act as the maneuver node for moving the connected assembly around.

Copy link
Member

@HunterBarclay HunterBarclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! We can ignore the issues with unit testing for now. They are being addressed in #996

@HunterBarclay
Copy link
Member

@Ewie21 Could you fix the merge conflict and update your fork branch to the Autodesk/synthesis branch?

Copy link
Contributor

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a quick double check after the merge then. Awesome job!

@HunterBarclay HunterBarclay merged commit f22f995 into Autodesk:dev Jun 27, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gameplay Relating to the playability of Synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants