-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motors in Drivers #1078
Motors in Drivers #1078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! Everything I tested has worked great so far, but I left a couple code suggestions below.
Also, to me it would make more sense for this panel to be called "motor configuration" instead of "joint configuration" because it also includes wheels, which I guess technically are joints but a lot of people won't think of wheels when they read "joints". Up to you though, might just be me
@LucaHaverty I had the same debate last year, but decided on joints because a lot of these are multi-motor, especially the drive. Do you have other ideas for joints? |
Oh yeah that's a good point. Maybe mechanisms or subsystems? I'm not sure though, joints works too. |
subsystems 👽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! Can't wait to mess around with this more once swerve is in
Co-authored-by: Brandon Pacewic <92102436+BrandonPacewic@users.noreply.github.com>
…n/dev' into crowela/1703/motors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not seem to find where to pull up the config panel. The subsystem button on main HUD appeared to do nothing and I failed to find where the driver config is in the new configure objects panel.
Looks like the panel got deleted from |
@BrandonPacewic @LucaHaverty Forgot to stage the Synthesis file. Thanks for catching it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪨 🧗
Description
Drivers have access to max velocity/acceleration and users can adjust them.
Objectives
Note
JIRA Issue