Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motors in Drivers #1078

Merged
merged 38 commits into from
Aug 15, 2024
Merged

Motors in Drivers #1078

merged 38 commits into from
Aug 15, 2024

Conversation

a-crowell
Copy link
Contributor

@a-crowell a-crowell commented Aug 2, 2024

Description

Drivers have access to max velocity/acceleration and users can adjust them.

Objectives

  • Drivers get and use max velocity/acceleration from preferences or the mirabuf file
  • Joint Configuration Panel with saving and canceling features

Note

  • Certain motors in the assemblies do not work. For example, 2018 sliders aren't given enough force to move. While I could clamp them as they come in, material is a big enough factor that it's easy enough to adjust in the panel.
  • While you'll see acceleration and force as umbrella terms for ease, SliderDrivers use force, HingeDrivers use torque, and WheelDrivers use acceleration. In the future, if we switch to using the vehicle controllers, WheelDrivers would use torque.

JIRA Issue

@a-crowell a-crowell requested review from HunterBarclay and a team as code owners August 2, 2024 01:09
@a-crowell a-crowell requested review from LucaHaverty and Dhruv-0-Arora and removed request for a team August 2, 2024 01:09
@a-crowell a-crowell self-assigned this Aug 2, 2024
@a-crowell a-crowell added the gameplay Relating to the playability of Synthesis label Aug 2, 2024
Copy link
Contributor

@LucaHaverty LucaHaverty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Everything I tested has worked great so far, but I left a couple code suggestions below.

Also, to me it would make more sense for this panel to be called "motor configuration" instead of "joint configuration" because it also includes wheels, which I guess technically are joints but a lot of people won't think of wheels when they read "joints". Up to you though, might just be me

@a-crowell
Copy link
Contributor Author

@LucaHaverty I had the same debate last year, but decided on joints because a lot of these are multi-motor, especially the drive. Do you have other ideas for joints?

@LucaHaverty
Copy link
Contributor

@LucaHaverty I had the same debate last year, but decided on joints because a lot of these are multi-motor, especially the drive. Do you have other ideas for joints?

Oh yeah that's a good point. Maybe mechanisms or subsystems? I'm not sure though, joints works too.

@a-crowell a-crowell requested a review from LucaHaverty August 5, 2024 16:10
@Dhruv-0-Arora
Copy link
Collaborator

@LucaHaverty I had the same debate last year, but decided on joints because a lot of these are multi-motor, especially the drive. Do you have other ideas for joints?

Oh yeah that's a good point. Maybe mechanisms or subsystems? I'm not sure though, joints works too.

subsystems 👽

@a-crowell a-crowell requested a review from LucaHaverty August 9, 2024 16:50
Copy link
Contributor

@LucaHaverty LucaHaverty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Can't wait to mess around with this more once swerve is in

@BrandonPacewic BrandonPacewic self-requested a review August 9, 2024 18:21
Co-authored-by: Brandon Pacewic <92102436+BrandonPacewic@users.noreply.github.com>
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not seem to find where to pull up the config panel. The subsystem button on main HUD appeared to do nothing and I failed to find where the driver config is in the new configure objects panel.

@LucaHaverty LucaHaverty self-requested a review August 13, 2024 05:00
@LucaHaverty
Copy link
Contributor

I could not seem to find where to pull up the config panel. The subsystem button on main HUD appeared to do nothing and I failed to find where the driver config is in the new configure objects panel.

Looks like the panel got deleted from Synthesis.tsx in a merge conflict :(

@a-crowell
Copy link
Contributor Author

@BrandonPacewic @LucaHaverty Forgot to stage the Synthesis file. Thanks for catching it!

Copy link
Contributor

@LucaHaverty LucaHaverty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨 🧗

@HunterBarclay HunterBarclay merged commit 96e0677 into dev Aug 15, 2024
12 checks passed
@HunterBarclay HunterBarclay deleted the crowela/1703/motors branch November 10, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gameplay Relating to the playability of Synthesis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants