Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar Buttons #1053

Merged
merged 14 commits into from
Jul 30, 2024
Merged

Toolbar Buttons #1053

merged 14 commits into from
Jul 30, 2024

Conversation

azaleacolburn
Copy link
Contributor

@azaleacolburn azaleacolburn commented Jul 26, 2024

Description

Add button that links to synthesis tutorials in the exporter toolbar.

Testing Done

  • Click the button and go to the website

JIRA Issue

@azaleacolburn azaleacolburn requested review from HunterBarclay and a team as code owners July 26, 2024 19:40
@azaleacolburn azaleacolburn requested review from PepperLola and BrandonPacewic and removed request for a team July 26, 2024 19:40
@PepperLola
Copy link
Contributor

PepperLola commented Jul 26, 2024

When the addon starts, I get an error saying that 'UI.Helper' has no attribute 'check_solid_open' in Synthesis.py:138.

If I change it to lambda *_: True like what the rest of the buttons have, the new button shows up and opens the website properly.

Also, could you run the formatter?

azaleacolburn and others added 3 commits July 26, 2024 16:03
@autodesk-chorus
Copy link

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement.

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azaleacolburn I would recommend running the format script in exporter/SynthesisFusionAddin/Synthesis.py if you are not already 🙃

Copy link
Contributor

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now

Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are still some left over formatting changes, for some reason some files are formatted to have max 80 character columns when it should be 120.

Reseting those files to their state on dev should do the trick.

Co-authored-by: azaleacolburn <azalea.colburn@autodesk.com>
Copy link
Member

@BrandonPacewic BrandonPacewic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reverted the formatting changes that occurred 🙃

@HunterBarclay HunterBarclay merged commit 84741b5 into dev Jul 30, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the colbura/1688/toolbar-buttons branch July 30, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants