Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Touchups v2 #1051

Merged
merged 9 commits into from
Jul 30, 2024
Merged

UI Touchups v2 #1051

merged 9 commits into from
Jul 30, 2024

Conversation

LucaHaverty
Copy link
Contributor

@LucaHaverty LucaHaverty commented Jul 26, 2024

Description

Made a new dropdown component that's similar to the input component and moved repeated style definitions into one place. These can be found in StyledComponents.tsx.

The new dropdown component now supports a default option, which can be used as follows:

<Dropdown
    defaultValue={"Option1"}
    options={["Option1", "Option2", "Option3", "Option4"]}
    onSelect={(val) => { }}
    label={"Dropdown Label"}
/>

Tasks

Merge brain config with manage assemblies, sequential joint config, intake config, ejector config, and possibly inputs (although inputs are cluttered enough as is). This might be big enough to be a separate PR
(Moved to a separate PR)

Images

Opened Dropdown

image

Feel free to request any other small UI changed you'd like on this PR!

Note

The bug with scroll views overflowing is fixed in #1063

JIRA Issue

@LucaHaverty LucaHaverty self-assigned this Jul 26, 2024
@LucaHaverty LucaHaverty added the ui/ux Relating to user interface, or in general, user experience label Jul 26, 2024
@LucaHaverty LucaHaverty marked this pull request as ready for review July 29, 2024 20:47
@LucaHaverty LucaHaverty requested review from HunterBarclay and a team as code owners July 29, 2024 20:47
@LucaHaverty LucaHaverty requested review from a-crowell and Dhruv-0-Arora and removed request for a team July 29, 2024 20:47
Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@a-crowell a-crowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I love how organized the SynthesisIcons makes it.

Copy link
Collaborator

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yum 😋

@HunterBarclay HunterBarclay merged commit 7ed733e into dev Jul 30, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the haverty/1775/ui-code-cleanup branch July 30, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants