-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Touchups v2 #1051
UI Touchups v2 #1051
Conversation
fission/src/ui/modals/configuring/theme-editor/ThemeEditorModal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I love how organized the SynthesisIcons makes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yum 😋
Description
Made a new dropdown component that's similar to the input component and moved repeated style definitions into one place. These can be found in
StyledComponents.tsx
.The new dropdown component now supports a default option, which can be used as follows:
Tasks
StyledComponents.tsx
.StyledComponents.tsx
.Merge brain config with manage assemblies, sequential joint config, intake config, ejector config, and possibly inputs (although inputs are cluttered enough as is). This might be big enough to be a separate PR(Moved to a separate PR)
Images
Opened Dropdown
Feel free to request any other small UI changed you'd like on this PR!
Note
The bug with scroll views overflowing is fixed in #1063
JIRA Issue