Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Types/**/* -> Types.py #1045

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Refactor: Types/**/* -> Types.py #1045

merged 1 commit into from
Jul 25, 2024

Conversation

BrandonPacewic
Copy link
Member

Moved many of the types (+ extras) into Types.py. Functionality unchanged. Trying to keep refactor diffs relatively small for easy reviewing. Just make sure nothing broke 🙃

@BrandonPacewic BrandonPacewic added exporter refactor The most important part of software development. labels Jul 24, 2024
@BrandonPacewic BrandonPacewic self-assigned this Jul 24, 2024
@BrandonPacewic BrandonPacewic requested review from HunterBarclay and a team as code owners July 24, 2024 21:55
@BrandonPacewic BrandonPacewic requested review from PepperLola and azaleacolburn and removed request for a team July 24, 2024 21:55
Copy link
Contributor

@PepperLola PepperLola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good and exporting still works.

Copy link
Contributor

@azaleacolburn azaleacolburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HunterBarclay HunterBarclay merged commit 472d60d into dev Jul 25, 2024
13 checks passed
@HunterBarclay HunterBarclay deleted the branp/types-refactor branch July 25, 2024 05:34
BrandonPacewic added a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter refactor The most important part of software development.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants