Skip to content

Commit fdd02e7

Browse files
MysteryemAustinSumigray
authored andcommitted
Tests: Fix indentation in TestTwoPlayerMulti (ArchipelagoMW#4010)
The "filling multiworld" subtest was at the wrong indentation, so was only running for the last world_type. "games" has additionally been added to the subtest to help better identify failures. Now that the subtest is actually being run for each world type, this adds about 20 seconds to the duration of the test on my machine.
1 parent 6bc5032 commit fdd02e7

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

test/multiworld/test_multiworlds.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def test_two_player_single_game_fills(self) -> None:
7171
for world in self.multiworld.worlds.values():
7272
world.options.accessibility.value = Accessibility.option_full
7373
self.assertSteps(gen_steps)
74-
with self.subTest("filling multiworld", seed=self.multiworld.seed):
75-
distribute_items_restrictive(self.multiworld)
76-
call_all(self.multiworld, "post_fill")
77-
self.assertTrue(self.fulfills_accessibility(), "Collected all locations, but can't beat the game")
74+
with self.subTest("filling multiworld", games=world_type.game, seed=self.multiworld.seed):
75+
distribute_items_restrictive(self.multiworld)
76+
call_all(self.multiworld, "post_fill")
77+
self.assertTrue(self.fulfills_accessibility(), "Collected all locations, but can't beat the game")

0 commit comments

Comments
 (0)