Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow time_utils.select_time_period to work on arrays containing NaNs #11

Closed
dougiesquire opened this issue Dec 2, 2021 · 1 comment · Fixed by #12
Closed

Allow time_utils.select_time_period to work on arrays containing NaNs #11

dougiesquire opened this issue Dec 2, 2021 · 1 comment · Fixed by #12
Assignees
@dougiesquire

Comments

@dougiesquire
Copy link
Collaborator

There is not (yet) any cftime('NaT') implementation (Unidata/cftime#145) and it is not uncommon to end up with float nans in time arrays. time_utils.select_time_period currently fails when there are Nans present but it would be great if it didn't.
@dougiesquire dougiesquire self-assigned this Dec 2, 2021
@dougiesquire
Copy link
Collaborator Author

I'll open a PR for this and use it as a way to demonstrate/describe the CI workflows I implemented in a previous PR (#9)

@dougiesquire dougiesquire mentioned this issue Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dougiesquire dougiesquire

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allowing time_utils.select_time_period to work on arrays containing NaNs dougiesquire/unseen
1 participant
@dougiesquire