Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization throws exception when config localization is set to an invalid setting #31

Open
AtriusX opened this issue Jun 21, 2021 · 0 comments
Labels
discussion Discussion for the direction of the project enhancement New feature or request

Comments

@AtriusX
Copy link
Owner

AtriusX commented Jun 21, 2021

This seems to be intended behavior based off the current implementation of Localizations, however I am debating on whether or not this should be changed to be a bit more clear to users. Exceptions aren't very helpful to people who don't know how to read them, so maybe it might be a better idea to default to english and return an error message in the console instead of completely breaking.

It also appears that an exception is thrown if english is not present in the jar file for whatever reason (this happened to @NathanAdhitya while testing #27 apparently). I don't feel like this specific part of behavior should change, since it reflects a problem with the jar file itself, but I'm open to alternative ideas if offered.

@AtriusX AtriusX added enhancement New feature or request discussion Discussion for the direction of the project labels Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion for the direction of the project enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant