Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket.io sample not working #789

Closed
stephaneeybert opened this issue Dec 25, 2012 · 5 comments
Closed

socket.io sample not working #789

stephaneeybert opened this issue Dec 25, 2012 · 5 comments

Comments

@stephaneeybert
Copy link

The socket.io sample code at https://github.com/Atmosphere/atmosphere/wiki/Getting-Started-with-Socket.IO is not working. This is no actual working javascript code. As a noob I tried to run the code as is but it gave a reference error: msg is not defined

Also, the bottom link to the complete sample code redirects to a long list of samples, from which it is not obvious which one is the socket.io sample.

@survivant
Copy link
Member

Hello, the socket.io extension was moved to https://github.com/Atmosphere/atmosphere-extensions

can you check there please.

and also, please, be more specific in your issue. What's not working ? Do you have a log, stacktrace, code that we can test with.

@stephaneeybert
Copy link
Author

Hello,

It is the sample code that was not working, not the socket.io itself.

When running the javascript socket.io code it complained that the msg variable was not defined, the actual message was: msg is not defined

This variable is referenced at line 25 of the code file:

socket.on('chat message', msg);

But is not previously set it seems.

@survivant
Copy link
Member

which release are you using ?
on which server ?
and which sample ?
which browsers did you try ?

error in the server logs ?

because socket.io samples are not in this repository, please switch the conversation on the atmosphere-extension repository.

if I have more details, I'll check it before the holidays vacation finish.

@jfarcand
Copy link
Member

Fixed the broken link, but the sample works fine.

@stephaneeybert
Copy link
Author

@survivant I had used the demo source code in the article https://github.com/Atmosphere/atmosphere/wiki/Getting-Started-with-Socket.IO and not one Git sample.

In that demo source code there is a:
socket.on('chat message', msg);

This msg was not declared previously according to my browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants