Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[atmosphere.js] Firefox/IE close tabs not detected #531

Closed
jfarcand opened this issue Jul 25, 2012 · 2 comments
Closed

[atmosphere.js] Firefox/IE close tabs not detected #531

jfarcand opened this issue Jul 25, 2012 · 2 comments
Labels

Comments

@jfarcand
Copy link
Member

As reported here

chrome:
<tab opened>
onSuspend : 34ff3a41-1df5-4411-956c-8bfbae7d8210
<page reloaded>
onDisconnect : 34ff3a41-1df5-4411-956c-8bfbae7d8210
onSuspend : 2e38b9ac-9f37-42ef-9959-ef39f1602503
<tab closed>
onDisconnect : 2e38b9ac-9f37-42ef-9959-ef39f1602503

ie9:
<tab opened>
onSuspend : 04797760-4e05-4ba8-b269-58e9286a112d
onDisconnect : 04797760-4e05-4ba8-b269-58e9286a112d
<page reloaded>
onSuspend : 9d435f73-0e76-4f35-9497-1a3a759897f4
onDisconnect : 9d435f73-0e76-4f35-9497-1a3a759897f4
<tab closed>
nothing

firefox:
<tab opened>
onSuspend : fa2c8d27-ce11-4625-b3bf-f7dde6ba7b1a
<page reloaded>
onSuspend : 9ec69d4d-bd66-4c35-9737-8e84ff58a20a
<tab closed>
nothing
<application closed>
onDisconnect : fa2c8d27-ce11-4625-b3bf-f7dde6ba7b1a
onDisconnect : 9ec69d4d-bd66-4c35-9737-8e84ff58a20a
@jfarcand
Copy link
Member Author

Fixed by

aa5a6ee

@flowersinthesand
Copy link
Member

As I said before - https://github.com/Atmosphere/atmosphere/pull/466/files#L0R31, this change may get existing apps using beforeunload event confused.

It would be good to add new option for this change. In jquery-socket, I'll treat obstructive but useful workarounds like this by providing a static method - https://github.com/flowersinthesand/jquery-socket/issues/49

Finally, I'm not sure beforeunload event is solution for this. It seems that the problem depends a combination of browser, transport and server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants