Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onMessage signature change dropped generics #391

Closed
drdozer opened this issue May 30, 2012 · 2 comments
Closed

onMessage signature change dropped generics #391

drdozer opened this issue May 30, 2012 · 2 comments
Assignees
Labels

Comments

@drdozer
Copy link

drdozer commented May 30, 2012

extras/gwt/atmosphere-gwt-client/src/main/java/org/atmosphere/gwt/client/AtmosphereListener.java

Signature of onMessage changed to:
public void onMessage(List messages)

This is bad because now List is not generified. Consider List<?> or List depending on what you intended. It used to be List<? extends Serializable>.

@pierreh
Copy link

pierreh commented May 30, 2012

Yes, the reason for this is that it would now be possible to also serialize JsonSerializable objects which do not need to be Serializable. I will change it to List

@pierreh
Copy link

pierreh commented May 30, 2012

Correction: List<?> is more flexible in taking other typed lists

@ghost ghost assigned pierreh May 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants