Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement : SSEAtmosphereInterceptor and JSONPAtmosphereInterceptor should be annoted #377

Closed
survivant opened this issue May 24, 2012 · 1 comment

Comments

@survivant
Copy link
Member

these 2 Interceptor could be annoted as : AtmosphereInterceptorService and remove from AtmosphereFramework.configureAtmosphereConfig()

// Add SSE support
interceptors.addLast(new SSEAtmosphereInterceptor());
// ADD JSONP support
interceptors.addLast(new JSONPAtmosphereInterceptor());

```java

but that imply that annotation-detector-3.0.0.jar will always be required.
@jfarcand
Copy link
Member

Salut, the idea is great, but I don't want to add a dependency on atmosphere-runtime (event if it is small jar). So closing the issue as will not fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants