-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChebyKAN is faster #7
Comments
That's great news. I have not updated the repo since 05/17/2024, so I have not kept up with the updates. Because of the speed with which everything unfolds, I included on purpose the date of the last benchmark, which is 5/17/2024. So, I think your observation is as of May 20 or 21, correct? |
I update my repo based on suggestions. I am not actively researching this area, when somebody creates an issue in my repo I try to include it. But I won't be looking around to see what has changed. I am like a process in STOPPED state waiting for a SIGCONT signal.
It seems like there is a repo here for that. I may add it in the future. Personally I think that paper should not pass any peer review process. Writing a paper in under two months is not a good idea. The production quality of that article is very low. And the experimental section is the bare minimum. Research should be done with patience. The urge to publish just degrades the quality of the results. People seem so afraid of missing out that they miss out good results mainly due to that fear alone. Instead of publishing the first thing that comes to your mind I believe it is better to mature the idea.
Like I mentioned above, people is in such a rush that they miss on good practices too. I hope my repo helps in giving proper atribution to every author. |
I added Wav-Kan to the benchmark. Very slow at the moment. |
Right now the ChebyKAN implementation is the fastest one. You are not including it in your README. If you want to claim that you are the fastest you should provide evidence that supports it. Specially now that I have run the benchmark on my machine and ChebyKAN appears to run faster than yours. The updated benchmarks in my repo is now as follows:
As you can see, the rbf-kan is also faster in the forward while being slower in the backward. And the chebykan is faster in both cases.
The text was updated successfully, but these errors were encountered: