Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Icons not rendering, even in release mode #69

Closed
codingiswhyicry opened this issue Feb 21, 2023 · 3 comments
Closed

Custom Icons not rendering, even in release mode #69

codingiswhyicry opened this issue Feb 21, 2023 · 3 comments
Labels
bug Something isn't working release blocker top priority stuff that is a blocker to launch

Comments

@codingiswhyicry
Copy link
Contributor

codingiswhyicry commented Feb 21, 2023

This is a relatively new and frustrating bug, related to something going on with Flutter. Was working previously. Even when running in release mode or building, the custom Assets file with our icons doesn't load, and continues to show the icon placeholder.

@codingiswhyicry codingiswhyicry added bug Something isn't working top priority stuff that is a blocker to launch release blocker labels Feb 21, 2023
@codingiswhyicry
Copy link
Contributor Author

Referenced here: ilikerobots/polyicon#81, not sure what the fix here is. We might need to switch to Material's icons for the example app instead of our custom ones.

@codingiswhyicry
Copy link
Contributor Author

Well, more is being uncovered. This seems to weirdly ONLY be an issue on browsers on desktops. I pulled up the Aureus website on my phone today and all of the icons rendered fine, so apparently it is compiling? And I'm not sure if this is a browser specific issue, because it seems to not show on Chrome OR Safari.

I need to make a bug report in the main flutter repo about this, but I'm not sure whether or not to let this block Astra's upcoming launches.

@codingiswhyicry
Copy link
Contributor Author

This has FINALLY been fixed! This is an issue with the render between desktop and mobile. That's why the issue wasn't visible on web and but was on mobile. In the future, if you experience this issue, make sure you are building and running using the HTML renderer! I'll make a self note to put this in documentation to be extra clear but the mystery is solved for now :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release blocker top priority stuff that is a blocker to launch
Projects
None yet
Development

No branches or pull requests

1 participant