Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still inconsistencies in DIT, NDIT etc. #464

Open
teutoburg opened this issue Sep 3, 2024 · 1 comment
Open

Still inconsistencies in DIT, NDIT etc. #464

teutoburg opened this issue Sep 3, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@teutoburg
Copy link
Contributor

Setting dit and ndit explicitely, I find those values in keywords DIT and NDIT. EXPTIME is at its default value and bears no relation to DIT and NDIT (with SummedExposure it should be the product, with the hypothetical AverageExposure it should be equal to DIT). The keywords HIERARCH ESO DET DIT is at mindit, and HIERARCH ESO DET NDIT is at 90.0 (a float!), these seem arbitrary.
The MJD-OBS is really DATE-OBS (format YYYY-MM-DDTHH:MM:SS).

Orignially from @oczoske on Slack.

@teutoburg teutoburg added the bug Something isn't working label Sep 3, 2024
@teutoburg teutoburg self-assigned this Sep 3, 2024
@hugobuddel
Copy link
Collaborator

(my comments copied from slack)

Thanks for this summary Oliver. I think no-one had been paying attention to the keywords for a while. For MICADO I wrote some round-trip tests. That is, simulate something from scratch, then read in the FITS headers and recreate the ScopeSim input from that, and then recreate the exact simulation again. However, it could be that I restricted that to NDIT=1, and I recall that the AutoExposure was not used, so EXPTIME was irrelevant. This sounds consistent with the problems you describe

Note that ScopeSim is in principle instrument independent. In particular, we cannot force ESO headers in ScopeSim itself. The headers should therefore be described in the IRDB, hence the creation of ExtraFitsKeywords.

@teutoburg teutoburg mentioned this issue Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants