Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Missed JSON-RPC methods #262

Closed
2 tasks
akru opened this issue Feb 3, 2021 · 8 comments
Closed
2 tasks

[EVM] Missed JSON-RPC methods #262

akru opened this issue Feb 3, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@akru
Copy link
Member

akru commented Feb 3, 2021

Description

Some standard JSON-RPC API functions missed in frontier implementation. This issue collects a list of missed methods and organizes implementation works.

Required Tasks

  • new_newFilter
  • ...
@akru akru added the enhancement New feature or request label Feb 3, 2021
@Maar-io
Copy link
Member

Maar-io commented Feb 3, 2021

Comparing EIP 1474 and Frontier master branch following is the list of not implemented methods:

  • eth_sign
  • eth_signTransaction
  • eth_getCompilers
  • eth_compileLLL
  • eth_compileSolidity
  • eth_compileSerpent

note: eth_newFilter and other filter methods are recently implemented in #274

Can you please explain what is the task related to implementation?
Is it to update Frontier submodule in Plasm with latest Frontier master, or to implement these methods in Frontier repo, or just to list missing methods?

@akru
Copy link
Member Author

akru commented Feb 4, 2021

Nice @Maar-io, thank you for update!
In that case, the target of this issue is updating frontier to upstream.

@Maar-io
Copy link
Member

Maar-io commented Feb 4, 2021

PR with latest PureStake frontier (3 commits behind Parity)
AstarNetwork/frontier#1

no merge conflicts found

@akru
Copy link
Member Author

akru commented Feb 5, 2021

@Maar-io Thank you very much, could you also create draft PR into this repo, dusty branch. Frontier used as sub-module.

@Maar-io
Copy link
Member

Maar-io commented Feb 5, 2021

.gitmodules is pointing to staketechnologies/frontier
and my PR above is for PlasmNetwork/frontier. My bad.
To update staketechnologies/frontier there are merge conflicts which need to be resolved.
@akru, I will attempt to resolve them

@akru
Copy link
Member Author

akru commented Feb 5, 2021

It should be changed to PlasmNetwork repo.

@Maar-io
Copy link
Member

Maar-io commented Feb 5, 2021

@akru please confirm that the following is needed:

  1. PlasmNetwork/Plasm repo to have PlasmNetwork/frontier as submodule.
  2. PlasmNetwork/frontier should be updated with the latest Parity/frontier master
  3. There are no changes on top of Parity/frontier that should be considered for merge
    thanks

@akru
Copy link
Member Author

akru commented Feb 5, 2021

That’s absolutely right, final step is check that everything works correctly: EVM contract deployment / executions, RPC calls, etc.

@akru akru closed this as completed Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants