Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store env in YAML #1403

Closed
wants to merge 1 commit into from

Conversation

NotNotARobot
Copy link

Pull Request Summary

It is considered best practice to store constant variables in the YAML context, rather than the bash context. This reduces the overhead on the machines, and makes them more robust against potential attacks.

Check list

  • [-] added or updated unit tests
  • [-] updated Astar official documentation
  • [-] added OnRuntimeUpgrade hook for precompile revert code registration
  • [-] added benchmarks & weights for any modified runtime logics.

@Dinonard
Copy link
Member

Dinonard commented Jan 8, 2025

Thank you for the PR, but to use your quote, we've learned that not accepting minor/irrelevant updates from unknown contributors is more robust against potential attacks 🙂.

@Dinonard Dinonard closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants