Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming __start to _start #983

Closed
dcodeIO opened this issue Nov 30, 2019 · 3 comments · Fixed by #994
Closed

Consider renaming __start to _start #983

dcodeIO opened this issue Nov 30, 2019 · 3 comments · Fixed by #994
Labels
enhancement

Comments

@dcodeIO
Copy link
Member

dcodeIO commented Nov 30, 2019

The --explicitStart option currently yields an export named __start, but it would be nice to align the name with WASI's _start function. There's still some discussion going on on the WASI side regarding that name, though, so we might have to reconsider something else later.
@dorin131
Copy link

dorin131 commented Dec 2, 2019

Is this a good first issue?
Could I give it a try?

@dcodeIO
Copy link
Member Author

dcodeIO commented Dec 2, 2019

I suspect you'd be disappointed of this as a first issue. It's mostly renaming at a couple places, but it's also a breaking change so it might make sense to collect more feedback before going for it.

@dorin131
Copy link

dorin131 commented Dec 2, 2019

Do we want then to wait and see what decision WASI comes to and take it from there?

In the meantime, could you point me to a good first issue or task please?

@dcodeIO dcodeIO mentioned this issue Dec 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename __start to _start AssemblyScript/assemblyscript
2 participants
@dcodeIO @dorin131