Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fromCharCodes & fromCodePoints polyfills #1340

Merged
merged 10 commits into from
Jun 14, 2020
Merged

Fix fromCharCodes & fromCodePoints polyfills #1340

merged 10 commits into from
Jun 14, 2020

Conversation

MaxGraey
Copy link
Member

Potentially fix #1324

  • I've read the contributing guidelines

std/portable/index.js Outdated Show resolved Hide resolved
@MaxGraey MaxGraey changed the title Use batching for fromCharCodes & fromCodePoints polyfills Fix fromCharCodes & fromCodePoints polyfills Jun 14, 2020
@MaxGraey

This comment has been minimized.

@dcodeIO
Copy link
Member

dcodeIO commented Jun 14, 2020

Hmm, question is how well it will perform in the worst case I guess. Let's say someone doesn't use a browser or runtime JITing these well. Or in an environment where the runtime is recent but JITing is disabled. It's unlikely, but if it happens, it can be really slow.

String.fromCodePoints mostly exists because there is no good alternative, more a feature for users than for the compiler itself.

@MaxGraey
Copy link
Member Author

I reverted recent changes already) Performance of CI is quite unstable. Will be great have online benchmark for compiler's speed

@dcodeIO
Copy link
Member

dcodeIO commented Jun 14, 2020

Also, now I'm wondering if we can use TextDecoder? Or would there be WTF issues, hmm.

@MaxGraey
Copy link
Member Author

TextDecoder also an option. But I prefer leave this as is currently. May be in future with more proper compiler's speed benchmark...

@dcodeIO
Copy link
Member

dcodeIO commented Jun 14, 2020

Sounds good to me :)

std/portable/index.js Outdated Show resolved Hide resolved
std/portable/index.js Outdated Show resolved Hide resolved
@dcodeIO dcodeIO merged commit 6dce0f2 into AssemblyScript:master Jun 14, 2020
@dcodeIO
Copy link
Member

dcodeIO commented Jun 14, 2020

Thanks :)

@MaxGraey MaxGraey deleted the fix-1324 branch June 14, 2020 23:20
@github-actions
Copy link

🎉 This PR is included in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded when compiling optimised code
2 participants