refactor: Rename (dtoa|itoa)_stream to (dtoa|itoa)_buffered + simplify signature #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @willemneal @jtenner Did you use |
MaxGraey
changed the title
|
Not directly. I do suppose I probably should be using it, but long.js works fine for me. |
dcodeIO
approved these changes
Jun 14, 2020
There was a problem hiding this comment.
Looks good to me! I remember that I've been using these directly in other parts of stdlib to avoid overhead, so there is a chance that users may have done this in their own programs. Suggesting to just increase the version to be safe (so most people will just skip over 0.11).
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better consistency I wanted to do this a long time ago.
Not sure is it breaking changing or not due to this methods usually used internally.