From 7b81cb2199e255197c144c43d4cd2ca952b5e06d Mon Sep 17 00:00:00 2001
From: Charanjeet Singh <chsingh@twilio.com>
Date: Wed, 27 Jul 2022 11:44:15 +0530
Subject: [PATCH] chore!: add node engine support from 14.x+ (#204)

Co-authored-by: shrutiburman <87537688+shrutiburman@users.noreply.github.com>
---
 .github/workflows/cli-core-audit.yml | 2 +-
 .github/workflows/cli-core-test.yml  | 2 +-
 .github/workflows/release.yml        | 6 +++---
 Dockerfile                           | 3 +--
 README.md                            | 3 +++
 package.json                         | 2 +-
 6 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/cli-core-audit.yml b/.github/workflows/cli-core-audit.yml
index c8d3e86a..e1cf3f9e 100644
--- a/.github/workflows/cli-core-audit.yml
+++ b/.github/workflows/cli-core-audit.yml
@@ -10,7 +10,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [16.x, 14.x, 12.x, 10.x]
+        node-version: [18.x, 16.x, 14.x]
     steps:
       - name: Checkout cli repo
         uses: actions/checkout@v2
diff --git a/.github/workflows/cli-core-test.yml b/.github/workflows/cli-core-test.yml
index 22a173c9..8c9c5c3c 100644
--- a/.github/workflows/cli-core-test.yml
+++ b/.github/workflows/cli-core-test.yml
@@ -10,7 +10,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [16.x, 14.x, 12.x, 10.x]
+        node-version: [18.x, 16.x, 14.x]
     steps:
       - name: Checkout cli core repo
         uses: actions/checkout@v2
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 496f8154..39be9fa9 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -44,7 +44,7 @@ jobs:
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws-session-token: ${{ secrets.AWS_SESSION_TOKEN }}
           aws-region: us-east-1
-  
+
   cli-token-validation:
     needs: [ cli-core-token-validation ]
     runs-on: ubuntu-latest
@@ -52,7 +52,7 @@ jobs:
       - name: Checkout cli-core repo
         uses: actions/checkout@v2
       - name: Execute py script to validate twilio-cli tokens
-        id: cli_token  
+        id: cli_token
         run: |
           output=$(python3 .github/scripts/validate_cli_tokens.py)
           echo "::set-output name=tokenStatus::$output"
@@ -87,7 +87,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [10.x, 12.x, 14.x, 16.x]
+        node-version: [14.x, 16.x, 18.x]
     steps:
       - name: Checkout cli-core repo
         uses: actions/checkout@v2
diff --git a/Dockerfile b/Dockerfile
index 284dee38..d48df26b 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,9 +1,8 @@
-FROM node:8-jessie
+FROM node:14.18.1
 RUN apt-get update && apt-get install -y libsecret-1-dev
 
 RUN mkdir /cli-core
 WORKDIR /cli-core
 COPY . .
-RUN npm install ./cli-test
 RUN npm install
 CMD ["npm", "test"]
diff --git a/README.md b/README.md
index 1ecd9289..e29e6446 100644
--- a/README.md
+++ b/README.md
@@ -4,6 +4,9 @@
 
 This module contains core functionality for the twilio-cli.
 
+## Requirements
+Currently, Node 14+ is supported. We support the [LTS versions](https://nodejs.org/en/about/releases) of Node.
+
 ## Base commands
 
 ### BaseCommand
diff --git a/package.json b/package.json
index 4c5064e5..7762d63a 100644
--- a/package.json
+++ b/package.json
@@ -68,6 +68,6 @@
     "keytar": "^7.6.0"
   },
   "engines": {
-    "node": ">=10.12.0"
+    "node": ">=14.0.0"
   }
 }