Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline not working in WebGL 1.0 builds #45

Closed
AGM-GR opened this issue Oct 29, 2021 · 2 comments
Closed

Outline not working in WebGL 1.0 builds #45

AGM-GR opened this issue Oct 29, 2021 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@AGM-GR
Copy link
Contributor

AGM-GR commented Oct 29, 2021

Setting Unity project as a WebGl project and the Graphic Api as WebGL 1.0, the outline works on editor but not in build. Also not working with Auto Graphic API in a machine that uses WebGL 1.0 so the problem could be a Shader implementation not compatible with the WebGL 1.0 restrictions.

imagen
imagen

Unity: 2020.3.16f1
URP: 10.5.1
UnityFX.Outline: Current repository version (1988f71)

Example project: OutlineWebGl1Bug.zip

@Arvtesh Arvtesh self-assigned this Nov 2, 2021
@Arvtesh
Copy link
Owner

Arvtesh commented Nov 2, 2021

I'll take a look, thanks.

@Arvtesh Arvtesh added the bug Something isn't working label Nov 14, 2021
@Arvtesh
Copy link
Owner

Arvtesh commented Nov 14, 2021

It's a WebGL 1.0 shader restrictions indeed. In WebGL 1.0 loop index be initialized to a non-constant value. So these lines are the problem:
image
I added the fix for v0.8.5.

@Arvtesh Arvtesh added this to the 0.8.5 milestone Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants