Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istanbul ignore flags are being ignored #342

Open
n0mbr3al3at0r10 opened this issue Feb 2, 2023 · 1 comment
Open

Istanbul ignore flags are being ignored #342

n0mbr3al3at0r10 opened this issue Feb 2, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@n0mbr3al3at0r10
Copy link

Describe a bug

Istanbul ignore flags like /* istanbul ignore next */ are being ignore, therefore the test coverage has statements not covered.

Expected behavior

Istanbul flags should be taken into account and this action should return the same result as running the test locally.

Details

  • Action version: 2.1.2

  • OS, where your action is running (windows, linux): linux

  • test.yml file
    name: test
    on: 
      pull_request:
        branches:
          - master
          - main
          - staging
    jobs:
      coverage:
        runs-on: ubuntu-latest
        steps:
          - uses: actions/checkout@v3.3.0
          - name: 'Create env file'
            run: |
              echo "${{ secrets.ENV_FILE }}" > .env
          - uses: ArtiomTr/jest-coverage-report-action@v2.1.2
            id: coverage
            with:
              package-manager: yarn
              test-script: yarn jest
              output: report-markdown
          - uses: marocchino/sticky-pull-request-comment@v2.3.1
            with:
              message: ${{ steps.coverage.outputs.report }}
  • Screenshots
    • GH Actions
      GitHub Actions

    • Local
      Local

@n0mbr3al3at0r10 n0mbr3al3at0r10 added the bug Something isn't working label Feb 2, 2023
@ArtiomTr
Copy link
Owner

ArtiomTr commented Feb 3, 2023

Hello @n0mbr3al3at0r10 👋,

Could you please share the command you're running, that is producing this output?

Local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants