Skip to content

Commit 7941e4b

Browse files
committedFeb 4, 2024
- test against up-to-date dependencies and PHP 8.3
- enable plugin instance sharing in provided simple plugin manager factories for strategies and validators
1 parent 5dda7a4 commit 7941e4b

File tree

7 files changed

+471
-519
lines changed

7 files changed

+471
-519
lines changed
 

‎.github/workflows/run-tests.yml

+2-3
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,9 @@ jobs:
1717
- php: '8.1'
1818
has_unique_dependencies: true
1919
- php: '8.2'
20+
- php: '8.3'
2021
upload_coverage: true
21-
#TODO test against PHP 8.3 when PHPSpec supports it
22-
#- php: '8.3'
23-
container: ghcr.io/articus/phpdbg-coveralls:${{ matrix.php }}_2.6.0_2023-12-18
22+
container: ghcr.io/articus/phpdbg-coveralls:${{ matrix.php }}_2.7.0_2024-01-08
2423
steps:
2524
- name: Workaround for https://git-scm.com/docs/git-config/2.39.2#Documentation/git-config.txt-safedirectory
2625
run: chown root:root ./

‎composer.lock

+162-230
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎composer.lock.7.4

+100-98
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎composer.lock.8.0

+64-62
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎composer.lock.8.1

+127-126
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/Articus/DataTransfer/Strategy/Factory/SimplePluginManager.php

+7
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,13 @@ protected function getServiceConfig(ContainerInterface $container): array
3232
'object' => 'Object',
3333
'objectArray' => 'ObjectArray',
3434
],
35+
'shares' => [
36+
Strategy\Whatever::class => true,
37+
Strategy\FieldData::class => true,
38+
Strategy\Identifier::class => true,
39+
'Object' => true,
40+
'ObjectArray' => true,
41+
],
3542
];
3643

3744
return array_merge_recursive($defaultConfig, parent::getServiceConfig($container));

‎src/Articus/DataTransfer/Validator/Factory/SimplePluginManager.php

+9
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,15 @@ protected function getServiceConfig(ContainerInterface $container): array
3636
'TypeCompliant' => Validator\TypeCompliant::class,
3737
'typeCompliant' => Validator\TypeCompliant::class,
3838
],
39+
'shares' => [
40+
Validator\NotNull::class => true,
41+
Validator\Whatever::class => true,
42+
Validator\Chain::class => true,
43+
Validator\Collection::class => true,
44+
Validator\FieldData::class => true,
45+
Validator\Identifier::class => true,
46+
Validator\TypeCompliant::class => true,
47+
],
3948
];
4049

4150
return array_merge_recursive($defaultConfig, parent::getServiceConfig($container));

0 commit comments

Comments
 (0)
Please sign in to comment.