Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testcontroller): add new properties to TestController typing #113

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

Arthy000
Copy link
Owner

No actual code changes for TestController:

  • Added the property testRun which itself has properties:
    --- Added the test property that gives access to name, meta and fixture name.
    --- Added fixtureCtx property.
  • Added many examples of hook usage (global hooks and tagg hooks)

No actual code changes for TestController:
- Added the property testRun which itself has
properties.
- Added the test property that gives access to name, meta and fixture name.
- Added
fixtureCtx property.
- Added many examples of hook usage (global hooks and tagg hooks)
Scenario: One tag - before
Given the scenario has a tag linked to a Before hook
Then the linked Before hook should have run

Copy link
Collaborator

@mrb1994 mrb1994 Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have 2 empty lines


Given(/a (BeforeAll|AfterAll) hook is defined/, async (t: TestController) => {
// TODO: try to find global hooks in t or testRun object
const tc = t as any;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe remove this

@Arthy000 Arthy000 merged commit 293dd77 into master Jan 17, 2023
@Arthy000 Arthy000 deleted the feature/typing branch January 17, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants