Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while linting after upgrading to 0.4.14 #56

Closed
bobdepreziz opened this issue Oct 29, 2024 · 1 comment
Closed

Crash while linting after upgrading to 0.4.14 #56

bobdepreziz opened this issue Oct 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@bobdepreziz
Copy link

bobdepreziz commented Oct 29, 2024

Hello,

I noticed a crash while linting after updating to version 0.4.14.

TypeError: Error while loading rule 'react-refresh/only-export-components': Cannot read properties of undefined (reading 'includes')
Occurred while linting /Users/bobd/mf-react-track-and-trace/lib/index.ts
at Object.create (/Users/bobd/mf-react-track-and-trace/node_modules/eslint-plugin-react-refresh/index.js:63:18)
at createRuleListeners (/Users/bobd/mf-react-track-and-trace/node_modules/eslint/lib/linter/linter.js:765:21)

If I look at where this comes from I see it is this includes on filename:

Screenshot 2024-10-29 at 14 54 29

I see that has been changed in this merge request:
https://github.com/ArnaudBarre/eslint-plugin-react-refresh/pull/54/files

Is this a bug on your end or are we doing something wrong configuration wise, with version 0.4.13 there are no issues.

@ArnaudBarre
Copy link
Owner

Oh yeah this changed bumped the implicit required peer version for ESLint to v8.40. This was not expected. If you bump ESLint to at least 8.40 it should be ok. I will update the code to be more backward compatible in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants