-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tester-cli: flags not forwarded when running command programmatically #2094
Comments
@Nigui Thanks for opening this issue, a maintainer will get back to you shortly! |
@air1one @faustbrian @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Tried to give TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
at up (~/Documents/projects/ark/core/node_modules/@oclif/config/lib/plugin.js:206:21)
at up.next (<anonymous>)
at findRoot (~/Documents/projects/ark/core/node_modules/@oclif/config/lib/plugin.js:212:14)
at Plugin.load (~/Documents/projects/ark/core/node_modules/@oclif/config/lib/plugin.js:25:28)
at Config.load (~/Documents/projects/ark/core/node_modules/@oclif/config/lib/config.js:28:22)
at Object.load (~/Documents/projects/ark/core/node_modules/@oclif/config/lib/config.js:307:18)
at Function.Command.run (~/Documents/projects/ark/core/node_modules/@oclif/command/lib/command.js:141:33)
at NFTMint.run (~/Documents/projects/ark/core/packages/core-tester-cli/dist/commands/nftmint.js:23:46)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. Maybe solution should be to manually forward flags, serializing as a string array and passing to |
Will take a look next week when I find time unless you've send a PR by then @Nigui. |
@Nigui This issue has been closed. If you wish to re-open it please provide additional information. |
Describe the bug
In the
Vote
command oftester-cli
,Transfer
command is called to initialize wallet balance (source)Overriding base command flags (like
p2pPort
) during thevote
command call, maketransfer
command crash due to invalid port used (default port of base command instead of source command port value).It produces the following error:
To Reproduce
Steps to reproduce the behavior:
p2pPort
is 4000 by default)core-tester-cli
yarn tester vote [...] --p2pPort 4000
Expected behavior
flags used in source command should be forwarded to programmatically called commands.
The text was updated successfully, but these errors were encountered: