Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi window support #11

Closed
Yamakaky opened this issue Sep 11, 2021 · 5 comments
Closed

Multi window support #11

Yamakaky opened this issue Sep 11, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Yamakaky
Copy link

When detecting window resize events, it doesn't check which window is resized. When multiple windows are used, events from other windows will affect egui. The fix is to check like this: https://github.com/Yamakaky/gyromouse/blob/gui/src/backend/sdl/overlay.rs#L221-L225.

https://github.com/ArjunNair/egui_sdl2_gl/blob/main/src/lib.rs#L54-L57

@ArjunNair
Copy link
Owner

Good point! I'll integrate that fix asap.

@ArjunNair ArjunNair self-assigned this Sep 12, 2021
@ArjunNair ArjunNair added the bug Something isn't working label Sep 12, 2021
@ArjunNair
Copy link
Owner

I've added the suggested fixes. Would appreciate it you can confirm they look good.

@Yamakaky
Copy link
Author

Just found out that we have the same problem for keyboard and mouse events. Fix: Yamakaky/gyromouse@55b26af

@ArjunNair
Copy link
Owner

Thanks. I've pushed changes to check for window id across events.

@Yamakaky
Copy link
Author

Sgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants