feat(guardrails): limit support to versions <0.5.2 #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
dosubot
bot
added
size:S
harrisonchu
changed the title
mikeldking
reviewed
Aug 21, 2024
| @@ -35,7 +35,7 @@ dependencies = [ | |||
|
|
|||
| [project.optional-dependencies] | |||
| instruments = [ | |||
| "guardrails-ai >= 0.4.5", | |||
| "guardrails-ai", | |||
There was a problem hiding this comment.
should this just be a range?
mikeldking
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after version 0.5.2 guardrails has major changes that makes the autoinstrumentor here useless. The package after that version also has native instrumentation that works quite well so we'll limit our tox testing to versions < 0.5.2 and for anyone that uses this instrumentor with a version of guardrails >= 0.5.2 the auto instrumentor will be a no op.