Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JSON string attributes #157

Merged
merged 7 commits into from
Feb 6, 2024
Merged

fix: JSON string attributes #157

merged 7 commits into from
Feb 6, 2024

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang commented Jan 29, 2024

resolves: #148

The following attributes should have JSON strings as values.

  • DOCUMENT_METADATA
  • LLM_PROMPT_TEMPLATE_VARIABLES
  • TOOL_PARAMETERS

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 29, 2024
@RogerHYang RogerHYang changed the title fix: JSONG string attributes fix: JSON string attributes Jan 29, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 29, 2024
Copy link
Contributor

@anticorrelator anticorrelator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 5, 2024
@RogerHYang RogerHYang merged commit 392057e into main Feb 6, 2024
4 checks passed
@RogerHYang RogerHYang deleted the json-string-attributes branch February 6, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
2 participants