Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove httpx dependency #1093

Merged
merged 5 commits into from
Oct 31, 2024
Merged

fix: remove httpx dependency #1093

merged 5 commits into from
Oct 31, 2024

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang commented Oct 31, 2024

this fixes Conda

@RogerHYang RogerHYang requested a review from a team as a code owner October 31, 2024 14:19
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 31, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 31, 2024
@@ -50,7 +50,10 @@ commands_pre =
bedrock-latest: uv pip install -U boto3
mistralai: uv pip install --reinstall {toxinidir}/instrumentation/openinference-instrumentation-mistralai[test]
mistralai-latest: uv pip install -U mistralai
openai: uv pip install --reinstall {toxinidir}/instrumentation/openinference-instrumentation-openai[test]
openai: uv pip uninstall -r test-requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes his uninstall necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for running locally, because the env is cached

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 31, 2024
@RogerHYang RogerHYang merged commit 41c6557 into main Oct 31, 2024
3 checks passed
@RogerHYang RogerHYang deleted the remove-dep branch October 31, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants