Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wpull spends a lot of time in add_cookie_header #117

Open
ivan opened this issue Dec 24, 2017 · 0 comments
Open

wpull spends a lot of time in add_cookie_header #117

ivan opened this issue Dec 24, 2017 · 0 comments
Labels
help wanted

Comments

@ivan
Copy link
Contributor

ivan commented Dec 24, 2017 •
edited
Loading

https://github.com/uber/pyflame + https://github.com/brendangregg/FlameGraph shows that for some crawls, 12-30% of the time is spent in add_cookie_header, which does a lot of URL parsing and clears the cookie jar too often (of which one component is a slow deepcopy).

Note: the configure step for pyflame is

PKG_CONFIG_PATH=~/.pyenv/versions/3.7.0/lib/pkgconfig ./configure

with uber-archive/pyflame#153 applied

flamegraphs.zip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivan